Skip to content

feat(bench): add prepocess and mimic RocksDB db_bench #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 30, 2022
Merged

feat(bench): add prepocess and mimic RocksDB db_bench #85

merged 15 commits into from
Jan 30, 2022

Conversation

@Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Jan 30, 2022 •
edited
Loading

What's changed and what's your intention?

  • Mimic RocksDB db_bench:
    • Some renames
    • Add some new options
    • Change the defaults of some options
    • Change the style of some doc statements to db_bench's style
  • Add prepocess_options function:
    • Check validity of input options
    • Would add more rules to it in future

Problems found:

  • Currently, the number of sequential read operations should be no larger than KV number of a single batch, because only one batch would be ingested. This is not cool.
  • Currently, operations of a --benchmarks are independent. Need to investigate how data reuse works between operations of a --benchmarks in db_bench.
  • The keys_per_prefix option in db_bench is more powerful than in ss_bench. Seems like an advanced feature.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#45

@Sunt-ing Sunt-ing requested review from lmatz and twocode January 30, 2022 09:23
@github-actions github-actions bot added the type/feature Type: New feature. label Jan 30, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #85 (ecc00ec) into main (586b7ad) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
- Coverage     74.48%   74.46%   -0.03%     
  Complexity     2645     2645              
============================================
  Files           825      828       +3     
  Lines         47343    47359      +16     
  Branches       1560     1560              
============================================
+ Hits          35265    35267       +2     
- Misses        11280    11294      +14     
  Partials        798      798
Flag Coverage Δ
java 61.91% <ø> (ø)
rust 79.96% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/bench/ss_bench/main.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/get_random.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/get_seq.rs 0.00% <0.00%> (ø)
...st/bench/ss_bench/operations/prefix_scan_random.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/write_batch.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/utils/workload.rs 0.00% <0.00%> (ø)
rust/common/src/test_utils/rand_array.rs 97.87% <0.00%> (ø)
rust/common/src/vector_op/agg.rs
rust/common/src/vector_op/agg/aggregator.rs 73.68% <0.00%> (ø)
rust/common/src/vector_op/agg/general_agg.rs 94.59% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586b7ad...ecc00ec. Read the comment docs.

@Sunt-ing Sunt-ing merged commit 3def2fe into main Jan 30, 2022
@Sunt-ing Sunt-ing deleted the sunt_mimic_ss_bench branch January 30, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@twocode twocode Awaiting requested review from twocode

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sunt-ing @lmatz