Skip to content

test(regress): enable jsonb #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2023
Merged

test(regress): enable jsonb #8181

merged 5 commits into from
Feb 27, 2023

Conversation

@xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Feb 24, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Enable regress tests for jsonb:

  • Unsupported functions are commented out. Tracking: jsonb operations #7714
  • create temp table is replaced by create table + drop table.
  • Updated ToText to use a customer Formatter to match PostgreSQL textual output.
  • For chained casts (v::T::U), specify output alias because our implicit name is T but PG uses U. This issue is not related to jsonb and we want to focus on testing jsonb casts here. frontend: Derive output column names #3812 (comment)

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

@github-actions github-actions bot added the A-test Area: Testing framework & misc tests not belonging to any specific component. label Feb 24, 2023
@xiangjinwu xiangjinwu marked this pull request as ready for review February 25, 2023 04:48
@codecov
Copy link

codecov bot commented Feb 25, 2023 •
edited
Loading

Codecov Report

Merging #8181 (7a11033) into main (7f237d7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #8181      +/-   ##
==========================================
- Coverage   71.85%   71.82%   -0.03%     
==========================================
  Files        1129     1129              
  Lines      181263   181303      +40     
==========================================
- Hits       130239   130225      -14     
- Misses      51024    51078      +54
Flag Coverage Δ
rust 71.82% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/jsonb_array.rs 16.83% <0.00%> (-2.69%) ⬇️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
...torage/src/hummock/local_version/pinned_version.rs 88.75% <0.00%> (-0.63%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (-0.52%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz lmatz added this pull request to the merge queue Feb 27, 2023
Merged via the queue into main with commit 59aec76 Feb 27, 2023
@lmatz lmatz deleted the test-regress-jsonb branch February 27, 2023 03:04
@xiangjinwu xiangjinwu linked an issue Feb 27, 2023 that may be closed by this pull request
test: enable PG regress test jsonb.sql #6175
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees

No one assigned

Labels

A-test Area: Testing framework & misc tests not belonging to any specific component.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: enable PG regress test jsonb.sql

4 participants

@xiangjinwu @lmatz @TennyZhuang