feat(catalog): add descriptor for cellbased table #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Mar 10, 2022
Comment on lines
5
to
7
| enum PhysicalTable { | ||
| CellBased(CellBasedTableDesc), | ||
| } |
Collaborator
There was a problem hiding this comment.
I would prefer simply TableDesc and refactor it once we do have other kind of tables. There is too much overdesign in our system... :(
fuyufjh
reviewed
Mar 10, 2022
Comment on lines
15
to
18
| pub pk: Vec<OrderedColumnDesc>, | ||
| // TODO: the other columns' descriptor, or all the columns? it is actually not used in the | ||
| // compute node... for the plan node include its requiring `columnDesc`. | ||
| // pub columns: Vec<ColumnDesc>, |
Codecov Report
@@ Coverage Diff @@
## main #815 +/- ##
============================================
- Coverage 72.23% 72.23% -0.01%
Complexity 2766 2766
============================================
Files 923 923
Lines 53664 53667 +3
Branches 1787 1787
============================================
+ Hits 38764 38765 +1
- Misses 14010 14012 +2
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fuyufjh
reviewed
Mar 10, 2022
| bool is_hidden = 2; | ||
| } | ||
|
|
||
| message CellBasedTableDesc { |
Collaborator
There was a problem hiding this comment.
recommend to add some comments
BugenZhao
approved these changes
Mar 10, 2022
yezizp2012
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)