feat: Convert GRPC results to Row #812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #812 +/- ##
============================================
+ Coverage 72.01% 72.02% +0.01%
Complexity 2766 2766
============================================
Files 925 926 +1
Lines 53935 53965 +30
Branches 1787 1787
============================================
+ Hits 38839 38868 +29
- Misses 14206 14207 +1
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
I think this should be placed in frontend because only the frontend needs it (or more precisely, only the PG protocol layer needs it) |
Yes I used to thought the It truly should be in frontend, |
rust/common/src/array/data_chunk.rs
Outdated
| if let Some(t) = s { | ||
| Some(t.to_string()) | ||
| } else { | ||
| None | ||
| } |
There was a problem hiding this comment.
s.map(|t| t.to_string())
There was a problem hiding this comment.
I think this should be placed in frontend because only the frontend needs it (or more precisely, only the PG protocol layer needs it)
+1
BowenXiao1999
left a comment
There was a problem hiding this comment.
Put it in utils in this PR?
Rest LGTM
Previously I indeed re-use DataChunk's row, however, to publish this as a library or crate, we can not use a struct in another non-open source project. I guess that's why @wangrunji0408 introduce a new simplified |
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
convert data_chunk to pg_response row
Checklist
Refer to a related PR or issue link (optional)
#810