Skip to content

Conversation

@soundOfDestiny
Copy link
Contributor

What's changed and what's your intention?

add read/write amount metrics for compaction

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #807 (0705952) into main (a8e90e5) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #807   +/-   ##
=========================================
  Coverage     72.41%   72.42%           
  Complexity     2759     2759           
=========================================
  Files           918      918           
  Lines         53227    53251   +24     
  Branches       1784     1784           
=========================================
+ Hits          38546    38568   +22     
- Misses        13789    13791    +2     
  Partials        892      892           
Flag Coverage Δ
java 61.12% <ø> (ø)
rust 77.17% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/hummock_manager.rs 77.50% <85.71%> (+0.41%) ⬆️
rust/meta/src/rpc/metrics.rs 40.54% <100.00%> (+5.24%) ⬆️
rust/meta/src/hummock/compaction.rs 82.24% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e90e5...0705952. Read the comment docs.

@soundOfDestiny soundOfDestiny requested a review from twocode March 9, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants