Skip to content

feat(optimizer): Introducing subquery removal rule. #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2022
Merged

feat(optimizer): Introducing subquery removal rule. #713

merged 3 commits into from
Mar 7, 2022

Conversation

@liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Mar 7, 2022

What's changed and what's your intention?

Introducing subquery removal rule.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

See #521

@liurenjie1024 liurenjie1024 requested review from fuyufjh and lmatz March 7, 2022 03:43
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 7, 2022
@liurenjie1024 liurenjie1024 enabled auto-merge (squash) March 7, 2022 03:43
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #713 (d741d50) into main (4a4534c) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #713      +/-   ##
============================================
- Coverage     71.72%   71.51%   -0.21%     
  Complexity     2706     2706              
============================================
  Files           898      900       +2     
  Lines         51670    51925     +255     
  Branches       1751     1781      +30     
============================================
+ Hits          37060    37136      +76     
- Misses        13795    13974     +179     
  Partials        815      815
Flag Coverage Δ
java 58.86% <0.00%> (-0.77%) ⬇️
rust 77.00% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ules/logical/subquery/FlinkSubQueryRemoveRule.java 0.00% <0.00%> (ø)
...gwave/planner/rel/streaming/RwStreamBatchPlan.java 55.55% <0.00%> (-20.21%) ⬇️
rust/meta/src/rpc/server.rs 71.42% <0.00%> (-19.75%) ⬇️
rust/common/src/util/mod.rs 0.00% <0.00%> (-15.39%) ⬇️
rust/storage/src/monitor/monitored_store.rs 16.41% <0.00%> (-13.44%) ⬇️
rust/meta/src/storage/meta_store.rs 88.88% <0.00%> (-11.12%) ⬇️
...frontend/src/optimizer/plan_node/logical_values.rs 47.05% <0.00%> (-10.09%) ⬇️
...frontend/src/optimizer/plan_node/logical_insert.rs 50.00% <0.00%> (-7.15%) ⬇️
rust/batch/src/executor/row_seq_scan.rs 48.78% <0.00%> (-4.88%) ⬇️
rust/server/tests/table_v2_materialize.rs 91.58% <0.00%> (-3.79%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4534c...d741d50. Read the comment docs.

@liurenjie1024 liurenjie1024 merged commit 56a6bdb into main Mar 7, 2022
@liurenjie1024 liurenjie1024 deleted the feat/renjie_subquery_remove branch March 7, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liurenjie1024 @lmatz