Skip to content

feat: support binding functions and unary exprs #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 7, 2022
Merged

feat: support binding functions and unary exprs #694

merged 9 commits into from
Mar 7, 2022

Conversation

@neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Mar 4, 2022 •
edited
Loading

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#338

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #694 (23e1fa6) into main (c7b006a) will decrease coverage by 0.00%.
The diff coverage is 67.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #694      +/-   ##
============================================
- Coverage     71.55%   71.55%   -0.01%     
  Complexity     2706     2706              
============================================
  Files           900      901       +1     
  Lines         51943    52018      +75     
  Branches       1781     1781              
============================================
+ Hits          37170    37219      +49     
- Misses        13958    13984      +26     
  Partials        815      815
Flag Coverage Δ
java 58.86% <ø> (ø)
rust 77.04% <67.01%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/error.rs 67.88% <0.00%> (ø)
rust/common/src/vector_op/cast.rs 6.66% <0.00%> (ø)
rust/frontend/src/binder/bind_context.rs 100.00% <ø> (ø)
rust/frontend/src/binder/mod.rs 100.00% <ø> (ø)
rust/frontend/src/expr/agg_call.rs 0.00% <0.00%> (ø)
rust/common/src/vector_op/substr.rs 84.61% <33.33%> (-5.13%) ⬇️
rust/frontend/tests/plan_test_runner.rs 72.88% <50.00%> (+0.95%) ⬆️
rust/frontend/src/binder/expr/mod.rs 65.95% <63.15%> (-11.83%) ⬇️
rust/frontend/src/binder/expr/function.rs 85.71% <85.71%> (ø)
rust/frontend/src/binder/expr/value.rs 90.69% <100.00%> (+0.69%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b006a...23e1fa6. Read the comment docs.

@fuyufjh fuyufjh requested review from likg227 and xiangjinwu March 4, 2022 03:58
xiangjinwu
xiangjinwu reviewed Mar 4, 2022
View reviewed changes
@neverchanje neverchanje marked this pull request as draft March 4, 2022 06:29
@neverchanje neverchanje marked this pull request as ready for review March 7, 2022 05:08
@neverchanje neverchanje merged commit 73ecac9 into main Mar 7, 2022
@neverchanje neverchanje deleted the wt-binder branch March 7, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

@likg227 likg227 Awaiting requested review from likg227

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neverchanje @xiangjinwu