Skip to content

fix: set default barrier interval to 1s (cont.) #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2022
Merged

fix: set default barrier interval to 1s (cont.) #6781

merged 5 commits into from
Dec 8, 2022

Conversation

@fuyufjh
Copy link
Collaborator

@fuyufjh fuyufjh commented Dec 7, 2022 •
edited
Loading

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #6553

@xxhZs I guess you chose in_flight_barrier_nums = 40 because 40 = 10s / 250ms so I changed it as well. Pleas correct me if not so.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

None.

Refer to a related PR or issue link (optional)

cont. of #6553

@fuyufjh fuyufjh requested review from xxhZs December 7, 2022 05:40
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Merging #6781 (a6fa92c) into main (533b9a9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #6781   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files        1024     1024           
  Lines      163813   163813           
=======================================
+ Hits       119962   119974   +12     
+ Misses      43851    43839   -12
Flag Coverage Δ
rust 73.23% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/config.rs 61.97% <0.00%> (ø)
...frontend/src/scheduler/hummock_snapshot_manager.rs 58.79% <0.00%> (+0.50%) ⬆️
src/batch/src/executor/group_top_n.rs 74.85% <0.00%> (+6.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuyufjh fuyufjh requested a review from xxchan December 8, 2022 08:46
@mergify mergify bot merged commit 8a86cc4 into main Dec 8, 2022
@mergify mergify bot deleted the eric/adjust_barrier_interval_2 branch December 8, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xxchan xxchan xxchan approved these changes

@xxhZs xxhZs Awaiting requested review from xxhZs

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fuyufjh @xxchan