Skip to content

Conversation

@BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 26, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

The APIs for fetching data from Prometheus to Dashboard are now complete. Dashboard will call /api/metrics/cluster API on dashboard service on meta node, and meta node will fetch recent data from Prometheus. The remaining things to decide are what data we want to show on dashboard and the style of charts.

image (5)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #5255

@github-actions github-actions bot added the type/feature Type: New feature. label Nov 26, 2022
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@skyzh skyzh force-pushed the bz2/dashboard-prometheus branch from eb7b834 to 37266cb Compare November 26, 2022 20:21
@skyzh skyzh requested review from cloudcarver and fuyufjh November 26, 2022 20:22
@skyzh skyzh added the user-facing-changes Contains changes that are visible to users label Nov 26, 2022
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #6602 (85441a4) into main (a07f267) will decrease coverage by 0.27%.
The diff coverage is 64.56%.

@@            Coverage Diff             @@
##             main    #6602      +/-   ##
==========================================
- Coverage   73.86%   73.59%   -0.28%     
==========================================
  Files        1002     1007       +5     
  Lines      162583   163389     +806     
==========================================
+ Hits       120088   120238     +150     
- Misses      42495    43151     +656     
Flag Coverage Δ
rust 73.59% <64.56%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/group_top_n.rs 68.42% <ø> (-6.44%) ⬇️
...batch/src/executor/join/distributed_lookup_join.rs 0.00% <0.00%> (ø)
src/batch/src/executor/join/nested_loop_join.rs 91.73% <ø> (ø)
src/batch/src/executor/join/sort_merge_join.rs 79.04% <ø> (ø)
src/batch/src/executor/order_by.rs 95.32% <ø> (ø)
src/batch/src/executor/project_set.rs 76.15% <ø> (ø)
src/batch/src/executor/sys_row_seq_scan.rs 0.00% <0.00%> (ø)
src/batch/src/executor/top_n.rs 75.00% <ø> (ø)
src/batch/src/executor/update.rs 81.36% <ø> (ø)
.../batch/src/task/consistent_hash_shuffle_channel.rs 0.00% <0.00%> (ø)
... and 174 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 77bb000 into main Nov 28, 2022
@mergify mergify bot deleted the bz2/dashboard-prometheus branch November 28, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: show node metrics on cluster overview

4 participants