Skip to content

feat(source): ban pk constraint on non materialized source #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 17, 2022
Merged

feat(source): ban pk constraint on non materialized source #6435

merged 6 commits into from
Nov 17, 2022

Conversation

@st1page
Copy link
Contributor

@st1page st1page commented Nov 17, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

We can not do the PRIMARY KEY constraint check on a non-materilaized source and recommend user using "CREATE MATERIALIZED SOURCE" instead

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Nov 17, 2022
@st1page st1page marked this pull request as ready for review November 17, 2022 08:31
BugenZhao
BugenZhao requested changes Nov 17, 2022
View reviewed changes
tabVersion
tabVersion approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #6435 (1aa02b3) into main (ddae931) will decrease coverage by 0.17%.
The diff coverage is 53.24%.

@@            Coverage Diff             @@
##             main    #6435      +/-   ##
==========================================
- Coverage   74.28%   74.10%   -0.18%     
==========================================
  Files         960      966       +6     
  Lines      156525   158144    +1619     
==========================================
+ Hits       116277   117197     +920     
- Misses      40248    40947     +699
Flag Coverage Δ
rust 74.10% <53.24%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 20.20% <ø> (-34.05%) ⬇️
src/batch/src/task/task_execution.rs 50.29% <0.00%> (ø)
src/common/src/types/chrono_wrapper.rs 46.66% <0.00%> (-15.91%) ⬇️
src/common/src/types/interval.rs 72.10% <0.00%> (-7.47%) ⬇️
src/common/src/types/mod.rs 72.40% <0.00%> (ø)
src/ctl/src/cmd_impl/table/scan.rs 0.00% <0.00%> (ø)
src/expr/src/expr/build_expr_from_prost.rs 53.76% <0.00%> (-1.91%) ⬇️
src/expr/src/expr/expr_binary_nonnull.rs 62.80% <0.00%> (-8.89%) ⬇️
src/expr/src/expr/mod.rs 47.91% <0.00%> (-1.02%) ⬇️
src/expr/src/vector_op/date_trunc.rs 0.00% <0.00%> (ø)
... and 148 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 7cfb296 into main Nov 17, 2022
@mergify mergify bot deleted the sts/ban_pk_on_non_materialized_source branch November 17, 2022 09:45
@hengm3467 hengm3467 mentioned this pull request Nov 18, 2022
Closed
xxchan pushed a commit that referenced this pull request Nov 19, 2022
@st1page @BugenZhao
@mergify @xxchan
feat(source): ban pk constraint on non materialized source (#6435)
e18fba3 
* feat(source): ban pk constraint on non materialized source

* Update src/frontend/src/handler/create_source.rs

Co-authored-by: Bugen Zhao <[email protected]>

* change e2e test to CREATE MATERIALIZED SOURCE

Co-authored-by: Bugen Zhao <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@CharlieSYH CharlieSYH mentioned this pull request Dec 1, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tabVersion tabVersion tabVersion approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@st1page @tabVersion @BugenZhao @lmatz