feat(streaming): add cache for materialize and handle pk conflict #6320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6320 +/- ##
==========================================
- Coverage 74.28% 74.10% -0.18%
==========================================
Files 960 966 +6
Lines 156525 157743 +1218
==========================================
+ Hits 116277 116899 +622
- Misses 40248 40844 +596
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
st1page
reviewed
Nov 15, 2022
…into wcy/add_cache_for_materialize
xxchan
pushed a commit
that referenced
this pull request
Nov 19, 2022
) * temp commit * framework * temp_commit * temp_commit * temp commit * framework done * temp commit * bug need to fix * need to add ut * ensure correctness * refactor * todo: add more unit test * todo: add comments, clean up code * todo: clean up code * typo fix * typo fix * refactor code * ready for review * code refactor * add e2e and ut * ready for review * dashboard * change cache row to compacted_row and add get_compacted_row for state table * change cache row to compacted_row and add get_compacted_row for state table * materialize cache do not store vnode in key * clean up state table get_row * materialize source handle pk conflict * merge main * merge main * mv check concurrent read * improve panic msg * fix * refine the code * clippy * Delete package-lock.json * Delete package.json Co-authored-by: Yuhao Su <[email protected]> Co-authored-by: st1page <[email protected]> Co-authored-by: stonepage <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR add cache for materialize executor and is used to do pk conflict check. If some cases like double insert or delete wrong value occurs, materialize need to fix it instead of ignore. Some unit tests are to verify the implement,
Checklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Release note
This PR has implemented the pk constraint check for the materialized source and table. If the following changes conflict with the existing record in storage, we will let the change overwrite the data in the table and the MVs which depend on it. This behavior also can support the "Upsert" connector. When the connector can not give the whole old value of the delete/update operations, It can just give the pk.
Refer to a related PR or issue link (optional)
close #6239
part of #5949