feat(frontend): implement system catalog schema: information_schema
#6227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenXiao1999
approved these changes
Nov 7, 2022
Contributor
BowenXiao1999
left a comment
There was a problem hiding this comment.
LGTM! Great Job.
We can replace Describe t; next
Codecov Report
@@ Coverage Diff @@
## main #6227 +/- ##
==========================================
+ Coverage 74.18% 74.57% +0.38%
==========================================
Files 944 945 +1
Lines 152310 152769 +459
==========================================
+ Hits 112992 113923 +931
+ Misses 39318 38846 -472
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Please add some description about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
information_schema. And addinformation_schema.columns.columnscontains columns intable,materialized view(except internal tables)andsystem table.table_idinstead oftable_name.TODO
information_schema.columns, we may need to modify the type system of RisingWave.information_schema.columns.information_schema, I will check it later.Checklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
information_schema(PostgreSQL's doc: https://www.postgresql.org/docs/current/information-schema.html).The information schema consists of a set of views that contain information about the objects defined in the current database.
information_schema.columns(PostgreSQL's doc: https://www.postgresql.org/docs/current/infoschema-columns.html).The view columns contains information about all table columns (or view columns) in the database. System columns (ctid, etc.) are not included. Only those columns are shown that the current user has access to (by way of being the owner or having some privilege). In RisingWave,
columnsalso contains all materialized views' columns.Refer to a related PR or issue link (optional)
relate #6149