Skip to content

feat(frontend): throw error when UserOptions has multiple conflicting or redundant options #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2022
Merged

feat(frontend): throw error when UserOptions has multiple conflicting or redundant options #5933

merged 3 commits into from
Oct 20, 2022

Conversation

@HuaHuaY
Copy link
Contributor

@HuaHuaY HuaHuaY commented Oct 19, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As the title.

Error message of PostgreSQL:

postgres=# create user tmp with createrole createrole;
ERROR:  conflicting or redundant options
LINE 1: create user tmp with createrole createrole;
                                        ^
postgres=# create user tmp with createrole nocreaterole;
ERROR:  conflicting or redundant options
LINE 1: create user tmp with createrole nocreaterole;
                                        ^
postgres=# alter user tmp with createdb createdb;
ERROR:  conflicting or redundant options
postgres=# alter user tmp with createdb nocreatedb;
ERROR:  conflicting or redundant options

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #5904

@HuaHuaY HuaHuaY requested a review from yezizp2012 October 19, 2022 14:58
@HuaHuaY HuaHuaY changed the title feat(frontend): throw error when create user or alter user has multiple conflicting or redundant options feat(frontend): throw error when UserOptions has multiple conflicting or redundant options Oct 19, 2022
@github-actions github-actions bot added the type/feature Type: New feature. label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #5933 (19175e6) into main (938f427) will increase coverage by 0.06%.
The diff coverage is 71.48%.

@@            Coverage Diff             @@
##             main    #5933      +/-   ##
==========================================
+ Coverage   74.89%   74.95%   +0.06%     
==========================================
  Files         924      924              
  Lines      147014   147464     +450     
==========================================
+ Hits       110104   110538     +434     
- Misses      36910    36926      +16
Flag Coverage Δ
rust 74.95% <71.48%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/monitor/process_linux.rs 60.29% <ø> (ø)
src/common/src/util/value_encoding/mod.rs 48.42% <ø> (+1.76%) ⬆️
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/table/scan.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/query.rs 20.49% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/generic.rs 83.33% <ø> (ø)
...ntend/src/optimizer/plan_node/stream_table_scan.rs 96.93% <ø> (ø)
src/frontend/src/planner/query.rs 100.00% <ø> (ø)
src/frontend/src/scheduler/error.rs 8.33% <ø> (ø)
... and 68 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yezizp2012
yezizp2012 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM~~

@mergify mergify bot merged commit 073f1bf into main Oct 20, 2022
@mergify mergify bot deleted the zehua/conflicting_redundant_options branch October 20, 2022 03:48
@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(frontend): throw error when create user or alter user has multiple conflicting or redundant options

4 participants

@HuaHuaY @yezizp2012 @lmatz