Skip to content

feat: zehao/modify rocksdb #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2022
Merged

feat: zehao/modify rocksdb #479

merged 3 commits into from
Feb 22, 2022

Conversation

@zehaowei
Copy link
Contributor

@zehaowei zehaowei commented Feb 22, 2022 •
edited
Loading

What's changed and what's your intention?

fix iter of rocksdb

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@zehaowei zehaowei requested a review from BugenZhao February 22, 2022 09:45
@zehaowei zehaowei changed the title Zehao/modify rocksdb feat: zehao/modify rocksdb Feb 22, 2022
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #479 (e40e798) into main (b2f373f) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #479      +/-   ##
============================================
- Coverage     72.93%   72.78%   -0.16%     
  Complexity     2711     2711              
============================================
  Files           872      872              
  Lines         48743    48719      -24     
  Branches       1554     1556       +2     
============================================
- Hits          35552    35458      -94     
- Misses        12380    12450      +70     
  Partials        811      811
Flag Coverage Δ
java 63.42% <ø> (-0.01%) ⬇️
rust 76.77% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/storage/src/rocksdb_local.rs 0.00% <0.00%> (ø)
rust/utils/pgwire/src/types.rs 80.00% <0.00%> (-20.00%) ⬇️
rust/meta/src/model/stream.rs 64.28% <0.00%> (-14.29%) ⬇️
rust/meta/src/barrier/info.rs 84.61% <0.00%> (-7.70%) ⬇️
rust/meta/src/stream/meta.rs 41.46% <0.00%> (-7.32%) ⬇️
rust/stream/src/executor/managed_state/join/mod.rs 58.71% <0.00%> (-7.08%) ⬇️
rust/stream/src/executor/project.rs 64.51% <0.00%> (-6.46%) ⬇️
rust/frontend/src/utils/column_index_mapping.rs 91.74% <0.00%> (-6.16%) ⬇️
rust/meta/src/rpc/intercept.rs 88.88% <0.00%> (-5.56%) ⬇️
rust/meta/src/model/catalog.rs 92.85% <0.00%> (-4.77%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f373f...e40e798. Read the comment docs.

@zehaowei zehaowei merged commit b2b9b53 into main Feb 22, 2022
@zehaowei zehaowei deleted the zehao/modify_rocksdb branch February 22, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

1 more reviewer

@skyzh skyzh skyzh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zehaowei @skyzh