Skip to content

feat: support parsing row type #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

feat: support parsing row type #463

merged 2 commits into from
Feb 22, 2022

Conversation

@neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Feb 22, 2022

What's changed and what's your intention?

https://www.postgresql.org/docs/14/sql-expressions.html#SQL-SYNTAX-ROW-CONSTRUCTORS

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #463 (3eccd9d) into main (e979278) will decrease coverage by 0.03%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #463      +/-   ##
============================================
- Coverage     72.93%   72.89%   -0.04%     
  Complexity     2711     2711              
============================================
  Files           872      872              
  Lines         48678    48721      +43     
  Branches       1554     1554              
============================================
+ Hits          35504    35516      +12     
- Misses        12363    12394      +31     
  Partials        811      811
Flag Coverage Δ
java 63.43% <ø> (ø)
rust 76.93% <92.85%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/sqlparser/src/parser.rs 92.83% <90.90%> (-0.02%) ⬇️
rust/sqlparser/src/ast/mod.rs 86.93% <100.00%> (+0.08%) ⬆️
rust/bench/ss_bench/operations/get_seq.rs 0.00% <0.00%> (ø)
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)
rust/bench/ss_bench/operations/get_random.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/write_batch.rs 0.00% <0.00%> (ø)
...st/bench/ss_bench/operations/prefix_scan_random.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e979278...3eccd9d. Read the comment docs.

@neverchanje neverchanje merged commit b57cd4e into main Feb 22, 2022
@neverchanje neverchanje deleted the wt-row branch February 22, 2022 03:20
@neverchanje neverchanje mentioned this pull request Feb 24, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neverchanje @liurenjie1024