feat(hummock): add aws-s3 dashboards for hummock monitor #413
Conversation
| let json_context = fs::read_to_string(&s3_dashboard_path)?; | ||
| fs::write(&s3_dashboard_path, json_context)?; | ||
| let yml = format!( | ||
| r#"# --- THIS FILE IS AUTO GENERATED BY RISEDEV --- |
There was a problem hiding this comment.
IIRC, Grafana yaml supports one yaml for multiple dashboards. No need to create two different yaml. You may merge this with the above function.
There was a problem hiding this comment.
We hope that risingwabe and third-party service(s3, ec2) on the different dashboards, whereas a grafana yml file corresponding to a dashboards
There was a problem hiding this comment.
A grafana yaml file can correspond to multiple dashboards. Anyway, I'm okay with the current approach.
| .to_string_lossy() | ||
| .to_string(); | ||
|
|
||
| let json_context = fs::read_to_string(&s3_dashboard_path)?; |
There was a problem hiding this comment.
There should be a fs::copy function?
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
============================================
- Coverage 72.91% 72.91% -0.01%
Complexity 2686 2686
============================================
Files 867 867
Lines 48898 48898
Branches 1579 1579
============================================
- Hits 35655 35653 -2
- Misses 12430 12432 +2
Partials 813 813
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
AWS-S3 provides CloudWatch and X-Ray for monitoring, this PR add aws-s3 monitoring in risingwave grafana dashboards, and s3 dashboards are as follows:
Checklist
Refer to a related PR or issue link (optional)
#326