This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: angular/angular-phonecat
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rhk98/angular-phonecat
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 15 files changed
- 2 contributors
Commits on May 9, 2014
-
- add ngApp directive to bootstrap the app - add simple template with an expression
Configuration menu - View commit details
-
Copy full SHA for cd3821c - Browse repository at this point
Copy the full SHA cd3821cView commit details -
- Added static html list with two phones into index.html
Configuration menu - View commit details
-
Copy full SHA for a202b2d - Browse repository at this point
Copy the full SHA a202b2dView commit details -
step-2 angular template with repeater
- Converted the static html list into dynamic one by: - creating PhoneListCtrl controller for the application - extracting the data from HTML into a the controller as an in-memory dataset - converting the static document into a template with the use of `[ngRepeat]` [directive] which iterates over the dataset with phones, clones the ngRepeat template for each instance and renders it into the view - Added a simple unit test to show off how to write tests and run them with Karma (see README.md for instructions)Configuration menu - View commit details
-
Copy full SHA for d7587b1 - Browse repository at this point
Copy the full SHA d7587b1View commit details -
- Added a search box to demonstrate how: - the data-binding works on input fields - to use [filter] filter - [ngRepeat] automatically shrinks and grows the number of phones in the view - Added an end-to-end test to: - show how end-to-end tests are written and used - to prove that the search box and the repeater are correctly wired together
Configuration menu - View commit details
-
Copy full SHA for 90ed2e7 - Browse repository at this point
Copy the full SHA 90ed2e7View commit details -
- Add "age" property to the phone model - Add select box to control phone list order - Override the default order value in controller - Add unit and e2e test for this feature
Configuration menu - View commit details
-
Copy full SHA for c5159d0 - Browse repository at this point
Copy the full SHA c5159d0View commit details -
step-5 XHR and dependency injection
- Replaced the in-memory dataset with data loaded from the server (in the form of static phone.json file to make this tutorial backend agnostic) - The json file is loaded using the [$http] service - Demonstrate the use of [services][service] and [dependency injection][DI] - The [$http] is injected into the controller through [dependency injection][DI]
Configuration menu - View commit details
-
Copy full SHA for f604542 - Browse repository at this point
Copy the full SHA f604542View commit details -
- adding phone image and links to phone pages - add end2end test that verifies our phone links - css to style the page just a notch
Configuration menu - View commit details
-
Copy full SHA for bf02434 - Browse repository at this point
Copy the full SHA bf02434View commit details -
step-7 $route and app partitioning
- Introduce the [$route] service which allows binding URLs for deep-linking with views - Create PhoneCatCtrl which governs the entire app and contains $route configuration - Load the ngRoute module - Map `/phones' to PhoneListCtrl and partails/phones-list.html - Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html - Copy deep linking parameters to root controller `params` property for access in sub controllers - Replace content of index.html with [ngView] directive - Create phone list route - Preserve existing PhoneListCtrl controller - Move existing html from index.html to partials/phone-list.html - Create phone details route - Empty placeholder PhoneDetailsCtrl controller - Empty placeholder partials/phane-details.html templateConfiguration menu - View commit details
-
Copy full SHA for 2280f78 - Browse repository at this point
Copy the full SHA 2280f78View commit details -
- Fetch data for and render phone detail view - PhoneDetailCtrl controller to fetch details json with [$http] for a specific phone - template for the phone detailed view - CSS to make the phone details page look "pretty"Configuration menu - View commit details
-
Copy full SHA for 7f98089 - Browse repository at this point
Copy the full SHA 7f98089View commit details -
- Added custom checkmark filter - Update phone detail template to use checkmark filter - Added spec for the filter
Configuration menu - View commit details
-
Copy full SHA for ef0a7b2 - Browse repository at this point
Copy the full SHA ef0a7b2View commit details -
step-10 image swapping with ng:click
In the phone detail view, clicking on a thumbnail image, changes the main phone image to be the large version of the thumbnail image. - Define mainImageUrl model variable in the PhoneDetailCtrl and set its default value - Create setImage controller method to change mainImageUrl - Register ng:click handler for thumb images to use setImage controller method - Add e2e tests for this feature - Add css to change the mouse cursor when user points at thumnail images
Configuration menu - View commit details
-
Copy full SHA for 7ad425c - Browse repository at this point
Copy the full SHA 7ad425cView commit details -
step-11 custom service and $resource
- Replaced [$http] with [$resource] - Created a custom Phone service that represents the $resource client
Configuration menu - View commit details
-
Copy full SHA for 1b61e44 - Browse repository at this point
Copy the full SHA 1b61e44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c20d92 - Browse repository at this point
Copy the full SHA 6c20d92View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master