Skip to content

[bug] Cannot Edit Group's Properties/Capabilities #4694

New issue
New issue
Closed
Closed
[bug] Cannot Edit Group's Properties/Capabilities#4694
Assignees
nnnnat
Labels
bugFor issues that describe a defect or regression in the released software
Milestone
Oxford
@jeffcorpuz

Description

@jeffcorpuz
jeffcorpuz
opened on Sep 29, 2018

Issue Description

Attempting to edit an existing group other than the first group's properties switches under Accounts in the Admin Side Panel clears the Accounts side panel and causes a console error.

Going back, the switch is toggled.

Note:
Newly created group's are not affected and behaving normally.

editGroup.js:42 Uncaught TypeError: Cannot read property '_id' of undefined
    at EditGroup.grp [as groupListClass] (editGroup.js:42)
    at React.createElement.state.groups.map (editGroup.js:153)
    at Array.map (<anonymous>)
    at EditGroup.renderGroups (editGroup.js:153)
    at EditGroup.render (editGroup.js:172)
    at finishClassComponent (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186784)
    at updateClassComponent (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186746)
    at beginWork (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187415)
    at performUnitOfWork (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189454)
    at workLoop (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189493)
EditGroup.grp @ editGroup.js:42
React.createElement.state.groups.map @ editGroup.js:153
renderGroups @ editGroup.js:153
render @ editGroup.js:172
finishClassComponent @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186784
updateClassComponent @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186746
beginWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187415
performUnitOfWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189454
workLoop @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189493
callCallback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173690
invokeGuardedCallbackDev @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173728
invokeGuardedCallback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173777
replayUnitOfWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:188901
renderRoot @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189553
performWorkOnRoot @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190151
performWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190073
performSyncWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190045
requestWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189945
scheduleWork$1 @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189809
enqueueSetState @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:184890
Component.setState @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:61199
onData @ compose.js:84
composer @ accountsDashboardContainer.js:148
Tracker.autorun @ tracker.js:40
_compute @ tracker.js:308
_recompute @ tracker.js:324
Tracker._runFlush @ tracker.js:495
onGlobalMessage @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:504
postMessage (async)
setImmediate @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:524
requireFlush @ tracker.js:129
invalidate @ tracker.js:264
changed @ tracker.js:422
self.collection._observeQueue.queueTask @ cursor.js:293
SQp.runTask @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:838
SQp.flush @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:867
SQp.drain @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:876
update @ local_collection.js:438
update @ collection.js:229
store.(anonymous function) @ livedata_connection.js:310
updateMessages.forEach.updateMessage @ livedata_connection.js:1192
keys.forEach.storeName @ livedata_connection.js:1191
_performWrites @ livedata_connection.js:1187
_flushBufferedWrites @ livedata_connection.js:1167
(anonymous) @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:1223
setTimeout (async)
_livedata_data @ livedata_connection.js:1148
onMessage @ livedata_connection.js:1663
forEachCallback.callback @ browser.js:186
forEachCallback @ common.js:30
socket.onmessage.data @ browser.js:185
REventTarget.dispatchEvent @ sockjs-0.3.4.js:87
SockJS._dispatchMessage @ sockjs-0.3.4.js:1072
SockJS._didMessage @ sockjs-0.3.4.js:1130
that.ws.onmessage @ sockjs-0.3.4.js:1277
modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187817 The above error occurred in the <Reaction(EditGroup)> component:
    in Reaction(EditGroup) (created by Tracker(Reaction(EditGroup)))
    in Tracker(Reaction(EditGroup)) (created by Reaction(ManageGroups))
    in div (created by Reaction(ManageGroups))
    in Reaction(ManageGroups) (created by Reaction(AccountsDashboard))
    in div (created by Reaction(AccountsDashboard))
    in div (created by Reaction(AccountsDashboard))
    in Reaction(AccountsDashboard) (created by withProps(Reaction(AccountsDashboard)))
    in withProps(Reaction(AccountsDashboard)) (created by Tracker(withProps(Reaction(AccountsDashboard))))
    in Tracker(withProps(Reaction(AccountsDashboard))) (created by Tracker(Tracker(withProps(Reaction(AccountsDashboard)))))
    in Tracker(Tracker(withProps(Reaction(AccountsDashboard))))
    in ApolloProvider

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
logCapturedError @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187817
logError @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187856
update.callback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:188509
callCallback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:184469
commitUpdateQueue @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:184513
commitLifeCycles @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187987
commitAllLifeCycles @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189053
callCallback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173690
invokeGuardedCallbackDev @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173728
invokeGuardedCallback @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:173777
commitRoot @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189194
completeRoot @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190209
performWorkOnRoot @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190154
performWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190073
performSyncWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:190045
requestWork @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189945
scheduleWork$1 @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189809
enqueueSetState @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:184890
Component.setState @ modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:61199
onData @ compose.js:84
composer @ accountsDashboardContainer.js:148
Tracker.autorun @ tracker.js:40
_compute @ tracker.js:308
_recompute @ tracker.js:324
Tracker._runFlush @ tracker.js:495
onGlobalMessage @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:504
postMessage (async)
setImmediate @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:524
requireFlush @ tracker.js:129
invalidate @ tracker.js:264
changed @ tracker.js:422
self.collection._observeQueue.queueTask @ cursor.js:293
SQp.runTask @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:838
SQp.flush @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:867
SQp.drain @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:876
update @ local_collection.js:438
update @ collection.js:229
store.(anonymous function) @ livedata_connection.js:310
updateMessages.forEach.updateMessage @ livedata_connection.js:1192
keys.forEach.storeName @ livedata_connection.js:1191
_performWrites @ livedata_connection.js:1187
_flushBufferedWrites @ livedata_connection.js:1167
(anonymous) @ meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:1223
setTimeout (async)
_livedata_data @ livedata_connection.js:1148
onMessage @ livedata_connection.js:1663
forEachCallback.callback @ browser.js:186
forEachCallback @ common.js:30
socket.onmessage.data @ browser.js:185
REventTarget.dispatchEvent @ sockjs-0.3.4.js:87
SockJS._dispatchMessage @ sockjs-0.3.4.js:1072
SockJS._didMessage @ sockjs-0.3.4.js:1130
that.ws.onmessage @ sockjs-0.3.4.js:1277
meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:1048 Exception from Tracker recompute function:
meteor.js?hash=0504f43f667698535416b00eb44eb6f53161cb63:1048 TypeError: Cannot read property '_id' of undefined
    at EditGroup.grp [as groupListClass] (editGroup.js:42)
    at React.createElement.state.groups.map (editGroup.js:153)
    at Array.map (<anonymous>)
    at EditGroup.renderGroups (editGroup.js:153)
    at EditGroup.render (editGroup.js:172)
    at finishClassComponent (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186784)
    at updateClassComponent (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:186746)
    at beginWork (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:187415)
    at performUnitOfWork (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189454)
    at workLoop (modules.js?hash=8fdeee8cdeeba0fae652935317835efda6c644bf:189493)

Steps to Reproduce

  1. Log-in as Admin account
  2. Click Accounts
  3. Edit an existing group's properties besides the first one (Shop Manager)

Movie:
https://drive.google.com/open?id=1qRHZtLC0ZaEoZAb9PHjCWCFtOMmUdY8c

Versions

Reaction 2.0.0-rc.2

Metadata

Metadata

Assignees

Labels

bugFor issues that describe a defect or regression in the released software

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions