Skip to content

Title attribute on cart items uses wrong value #4606

@mikemurray

Description

@mikemurray

Issue Description

Item attributes when items are added to the cart are displayed incorrectly in the starter-kit and in the cart items component from the component library. Namely having the title attribute uses the optionTitle instead of title.

Possible Solution

Here: https://github.com/reactioncommerce/reaction/blob/release-1.16.0/imports/plugins/core/cart/server/no-meteor/util/addCartItems.js#L99

  1. Use optionTitle from the parent variant if available, otherwise...
  2. Use title from the chosen variant
  3. Add label: null for the future to be clear that there will be a label.

Versions

Node: 10.7.0
NPM: 6.2.0
Meteor Node: 8.11.3
Meteor NPM: 5.10.0
Reaction CLI: 0.29.0
Reaction: 1.16.0
Reaction branch: release-1.16.0
Docker: 18.06.0-ce

Metadata

Metadata

Assignees

Labels

bugFor issues that describe a defect or regression in the released software

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions