Expected behavior

From https://docs.reactioncommerce.com/reaction-docs/master/configuration#environment-variables

_Note: Environment variables will override variables set in settings.json_

The expected behaviour is that if you set ENV variables it will always use these instead of values in settings.json. This is how it does work if you are using meteor instead of reaction-cli.

Actual Behavior

In run.js we're adding --settings dev.settings if no settings.json exists, which is fine, but changes older behaviour where we simply never loaded dev.settings -> it was just an example file.

Because we now are loading, dev.settings, the default user/email/pass are being set to "" and the env variables are never used.