Fix new clippy::use_self warnings

ctz · ctz · commit ffd933a9fe9a · 2024-03-25T14:23:58.000Z
Seems this has improved when the explicit lifetime bound is
the same as the one implied in `Self`.
diff --git a/rustls/src/client/client_conn.rs b/rustls/src/client/client_conn.rs
@@ -495,7 +495,7 @@ pub struct WriteEarlyData<'a> {
 }
 
 impl<'a> WriteEarlyData<'a> {
-    fn new(sess: &'a mut ClientConnection) -> WriteEarlyData<'a> {
+    fn new(sess: &'a mut ClientConnection) -> Self {
         WriteEarlyData { sess }
     }
 
diff --git a/rustls/src/conn.rs b/rustls/src/conn.rs
@@ -268,7 +268,7 @@ impl<'a> Writer<'a> {
     ///
     /// This is not an external interface.  Get one of these objects
     /// from [`Connection::writer`].
-    pub(crate) fn new(sink: &'a mut dyn PlaintextSink) -> Writer<'a> {
+    pub(crate) fn new(sink: &'a mut dyn PlaintextSink) -> Self {
         Writer { sink }
     }
 }
diff --git a/rustls/src/msgs/codec.rs b/rustls/src/msgs/codec.rs
@@ -268,7 +268,7 @@ impl<'a> LengthPrefixedBuffer<'a> {
     ///
     /// After this, the body of the length-delimited structure should be appended to `LengthPrefixedBuffer::buf`.
     /// The length header is corrected in `LengthPrefixedBuffer::drop`.
-    pub(crate) fn new(size_len: ListLength, buf: &'a mut Vec<u8>) -> LengthPrefixedBuffer<'a> {
+    pub(crate) fn new(size_len: ListLength, buf: &'a mut Vec<u8>) -> Self {
         let len_offset = buf.len();
         buf.extend(match size_len {
             ListLength::U8 => &[0xff][..],
diff --git a/rustls/src/webpki/verify.rs b/rustls/src/webpki/verify.rs
@@ -119,7 +119,7 @@ pub struct ParsedCertificate<'a>(pub(crate) webpki::EndEntityCert<'a>);
 
 impl<'a> TryFrom<&'a CertificateDer<'a>> for ParsedCertificate<'a> {
     type Error = Error;
-    fn try_from(value: &'a CertificateDer<'a>) -> Result<ParsedCertificate<'a>, Self::Error> {
+    fn try_from(value: &'a CertificateDer<'a>) -> Result<Self, Self::Error> {
         webpki::EndEntityCert::try_from(value)
             .map_err(pki_error)
             .map(ParsedCertificate)

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,7 @@ pub struct WriteEarlyData<'a> {`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`impl<'a> WriteEarlyData<'a> {`
`498`		`- fn new(sess: &'a mut ClientConnection) -> WriteEarlyData<'a> {`
	`498`	`+ fn new(sess: &'a mut ClientConnection) -> Self {`
`499`	`499`	`WriteEarlyData { sess }`
`500`	`500`	`}`
`501`	`501`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ impl<'a> Writer<'a> {`
`268`	`268`	`///`
`269`	`269`	`/// This is not an external interface. Get one of these objects`
`270`	`270`	/// from [`Connection::writer`].
`271`		`- pub(crate) fn new(sink: &'a mut dyn PlaintextSink) -> Writer<'a> {`
	`271`	`+ pub(crate) fn new(sink: &'a mut dyn PlaintextSink) -> Self {`
`272`	`272`	`Writer { sink }`
`273`	`273`	`}`
`274`	`274`	`}`