Fix group blend mode returning None with minimal section divider data #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a group's section divider setting exists but has minimal content (e.g., blend_mode is None), the blend_mode property was incorrectly returning None instead of falling back to the parent layer's blend_mode. This fix adds an additional check to ensure the setting's blend_mode is not None before using it. Fixes #513 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #513 - Group blend mode was incorrectly returning
Nonewhen the section divider setting existed but had minimal content (e.g.,blend_modefield wasNone).The fix adds an additional check to ensure
setting.blend_mode is not Nonebefore using it, falling back to the parent layer's blend_mode when it's not set.Changes
Group.blend_modeproperty in layers.py to check bothsetting is not Noneandsetting.blend_mode is not Nonetest_group_blend_mode()to verify the fixTest plan
test_layers.py)🤖 Generated with Claude Code