-
Notifications
You must be signed in to change notification settings - Fork 110
Open
Labels
bugSomething isn't workingSomething isn't working
Description
If a new param is an invalid JSON string, or the type doesn't match the define one, the protocol just accepts without changing the state. The bug is this line doesn't respect the returned error.
pocket-core/x/gov/keeper/subspace.go
Line 216 in 003a959
_ = space.Update(ctx, []byte(paramKey), paramValue) |
Ideally we should fix this on protocol side. Given that this product is maintenance mode, however, my suggestion is to add some check on client side to prevent it from submitting a tx with an invalid param value.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
No status