Skip to content

Conversation

@microsoldering1
Copy link
Collaborator

@microsoldering1 microsoldering1 commented Jun 3, 2021

Long words are bad.

Description

There is an interesting result when a message contains a really long word. The page will infinitely get wider,and as a result all other messages that would have otherwise wrapped do not.

wordbreak_pm

The issue can be corrected by using word-break, and breaking a word that exceeds the width of its container. It shouldn't break other words, only those that are too long to fit. So there should be no visual change for anyone unless they encounter one of these messages.

wordbreak_pm_after

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on my own instance

correct issue where long words result in unintended layout
@DanrwAU DanrwAU self-requested a review June 4, 2021 10:16
@DanrwAU DanrwAU added the UI label Jun 4, 2021
@DanrwAU DanrwAU added this to the 0.3.11 milestone Jun 4, 2021
DanrwAU
DanrwAU previously approved these changes Jun 4, 2021
Copy link
Member

@DanrwAU DanrwAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this may fix some of the issues we've been having with i devices too

@DanrwAU DanrwAU merged commit 50109a8 into pagermon:develop Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants