Skip to content

GH-93516: Store offset of first traceable instruction in code object #93769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 4 commits into from
Jun 14, 2022
Merged

GH-93516: Store offset of first traceable instruction in code object #93769

markshannon merged 4 commits into from
Jun 14, 2022

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Jun 13, 2022

Avoids having to recompute the offset all the time when tracing.

@markshannon markshannon mentioned this pull request Jun 13, 2022
Closed
@markshannon
Copy link
Member Author

markshannon commented Jun 13, 2022

Blocked by #93771

@gvanrossum
Copy link
Member

gvanrossum commented Jun 13, 2022

As an experiment, can you remove the "import opcode" from deepfreeze.py and hardcode the RESUME opcode? We can debate whether that's the right fix, but so far the deepfreeze.py script has been carefully designed not to depend on the details of the target version.

@gvanrossum
Copy link
Member

gvanrossum commented Jun 13, 2022

Did you consider putting the new field in the marshaled code object? Then deepfreeze.py wouldn't have to import opcode.

@markshannon
Copy link
Member Author

markshannon commented Jun 13, 2022

Did you consider putting the new field in the marshaled code object?

Yes, but I decided against it.
This PR needs backporting to 3.11, so I want to keep it as small as possible, and it is already quite large.