gh-128035: Add ssl.HAS_PHA to detect libssl PHA support #128036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Dec 17, 2024
Member
tomasr8
left a comment
There was a problem hiding this comment.
This will also need a news entry :)
picnixz
reviewed
Dec 17, 2024
| @@ -0,0 +1 @@ | |||
| TLSv1.3 post-handshake client authentication (PHA), often referred to as "mutual TLS" or "mTLS", allows TLS servers to authenticate client identities using digital certificates. This commit exposes a boolean property ``ssl.HAS_PHA`` to indicate whether the crypto library CPython is built against supports PHA, allowing python's test suite and consuming modules to branch accordingly. | |||
Member
There was a problem hiding this comment.
A shorter NEWS should be written. The NEWS is a message that users will see (it's in the changelog). Some suggestion:
Indicate through :data:`ssl.HAS_PHA` whether the :mod:`ssl` module supports TLSv1.3
post-handshake client authentication (PHA). Patch by YOURNAME.In addition, you should add a What's New entry in Doc/whatsnew/3.14.rst indicating the additional constant. Usually, the same message as for the NEWS entry can be reused (check the other entries for the formatting).
Contributor
Author
There was a problem hiding this comment.
Thank you for the guidance. I've updated the news and whatsnew files accordingly.
tomasr8
reviewed
Dec 17, 2024
Doc/whatsnew/3.14.rst
Outdated
Comment on lines
73
to
75
| * Indicate through :data:`ssl.HAS_PHA` whether the :mod:`ssl` module supports TLSv1.3 | ||
| post-handshake client authentication (PHA). (Contributed by Will Childs-Klein in | ||
| :gh:`128036`.) |
Member
There was a problem hiding this comment.
This should go under Improved modules. You can make a new section for ssl:
ssl
---
* Indicate through :data:`ssl.HAS_PHA` whether the :mod:`ssl` module supports TLSv1.3
post-handshake client authentication (PHA). (Contributed by Will Childs-Klein in
:gh:`128036`.)7f19054 to
6b11e12
Compare
Notes
Please see #128035's description.
Testing
📚 Documentation preview 📚: https://cpython-previews--128036.org.readthedocs.build/