test_inspect_wrapped_property: handle fixed wrapper inspection

AdamWill · AdamWill · commit 79603849818e · 2024-06-14T23:06:50.000-07:00
Python upstream recently fixed the behavior of inspect with wrappers: python/cpython#112006 . The assertion here relies on the broken behavior, we only get None if `inspect(Wrapped)` fails and raises `ValueError`. Now it works, we actually get the correct answer, 1. This changes it so we assert the correct thing depending on the Python version (the fix was backported to 3.11.9 and 3.12.3, so the check has to be a bit complicated). Signed-off-by: Adam Williamson <awilliam@redhat.com>
diff --git a/toolz/tests/test_inspect_args.py b/toolz/tests/test_inspect_args.py
@@ -2,6 +2,7 @@
 import inspect
 import itertools
 import operator
+import sys
 import toolz
 from toolz.functoolz import (curry, is_valid_args, is_partial_args, is_arity,
                              num_required_args, has_varargs, has_keywords)
@@ -482,6 +483,23 @@ def __wrapped__(self):
     wrapped = Wrapped(func)
     assert inspect.signature(func) == inspect.signature(wrapped)
 
-    assert num_required_args(Wrapped) is None
-    _sigs.signatures[Wrapped] = (_sigs.expand_sig((0, lambda func: None)),)
-    assert num_required_args(Wrapped) == 1
+    # inspect.signature did not used to work properly on wrappers,
+    # but it was fixed in Python 3.11.9, Python 3.12.3 and Python
+    # 3.13+
+    inspectbroken = True
+    if sys.version_info.major > 3:
+        inspectbroken = False
+    if sys.version_info.major == 3:
+        if sys.version_info.minor == 11 and sys.version_info.micro > 8:
+            inspectbroken = False
+        if sys.version_info.minor == 12 and sys.version_info.micro > 2:
+            inspectbroken = False
+        if sys.version_info.minor > 12:
+            inspectbroken = False
+
+    if inspectbroken:
+        assert num_required_args(Wrapped) is None
+        _sigs.signatures[Wrapped] = (_sigs.expand_sig((0, lambda func: None)),)
+        assert num_required_args(Wrapped) == 1
+    else:
+        assert num_required_args(Wrapped) == 1
