Skip to content

Conversation

@kyubisation
Copy link
Contributor

The fixtures currently look for the wtr-session-id query string. This PR adds a fallback, when wtr-session-id is not found, to look for the first URL that does not contain node_modules or the path to the fixture file.

Fixes #4067

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 1f23a6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@augustjk augustjk merged commit ff87eb4 into lit:main Aug 19, 2024
@kyubisation kyubisation deleted the fix-testing-webkit-call-site-location branch August 19, 2024 21:16
@lit-robot lit-robot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[labs/testing] Call site location by stack trace might not work in webkit

2 participants