Ensure protected methods aren't renamed

kevinpschaaf · kevinpschaaf · commit 5036725fb0d2 · 2021-08-09T18:02:53.000-07:00
diff --git a/packages/lit-html/src/directives/async-append.ts b/packages/lit-html/src/directives/async-append.ts
@@ -21,7 +21,7 @@ import {
 class AsyncAppendDirective extends AsyncReplaceDirective {
   private __childPart!: ChildPart;
 
-  protected __validatePartType(partInfo: PartInfo) {
+  protected validatePartType(partInfo: PartInfo) {
     if (partInfo.type !== PartType.CHILD) {
       throw new Error('asyncAppend can only be used in child expressions');
     }
diff --git a/packages/lit-html/src/directives/async-replace.ts b/packages/lit-html/src/directives/async-replace.ts
@@ -33,11 +33,11 @@ export class AsyncReplaceDirective extends AsyncDirective {
 
   constructor(partInfo: PartInfo) {
     super(partInfo);
-    this.__validatePartType(partInfo);
+    this.validatePartType(partInfo);
   }
 
   // Override point for AsyncReplace, which can only be used in ChildParts
-  protected __validatePartType(_partInfo: PartInfo) {
+  protected validatePartType(_partInfo: PartInfo) {
     // AsyncReplace can be used in any part type
   }
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ import {`
`21`	`21`	`class AsyncAppendDirective extends AsyncReplaceDirective {`
`22`	`22`	`private __childPart!: ChildPart;`
`23`	`23`
`24`		`- protected __validatePartType(partInfo: PartInfo) {`
	`24`	`+ protected validatePartType(partInfo: PartInfo) {`
`25`	`25`	`if (partInfo.type !== PartType.CHILD) {`
`26`	`26`	`throw new Error('asyncAppend can only be used in child expressions');`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,11 @@ export class AsyncReplaceDirective extends AsyncDirective {`
`33`	`33`
`34`	`34`	`constructor(partInfo: PartInfo) {`
`35`	`35`	`super(partInfo);`
`36`		`- this.__validatePartType(partInfo);`
	`36`	`+ this.validatePartType(partInfo);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`// Override point for AsyncReplace, which can only be used in ChildParts`
`40`		`- protected __validatePartType(_partInfo: PartInfo) {`
	`40`	`+ protected validatePartType(_partInfo: PartInfo) {`
`41`	`41`	`// AsyncReplace can be used in any part type`
`42`	`42`	`}`
`43`	`43`