Fix miter join in dashed strokes #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platlas
approved these changes
Aug 26, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Missed updating `CHANGELOG.md` in #490, fixing it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482
before.mov
after.mov
Essentially, the problem was that when a miter point was detected, it was added only on one side, which caused incorrect behavior in some cases. Below is a quick diagram showing what was happening before and after the fix for path
M70,80 L0,80 L0,77.I also verified the output against tiny-skia with identical rectangle parameters and stroke styles, and it matches now.