fix: state output values are json #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State output values were being treated like a string throughout the codebase, but of course they can be one of number of different terraform data types.
Terraform types translate to JSON types, so this PR changes the output value to be a
json.RawMessage. The PR would also migrate the postgres type from string to JSONB, but thego-tfeintegration tests we use rely on whitespace being preserved when comparing for equality; I tried using JSON postgres type but that broke the queries we use because that type doesn't "have an equality operator". So we'll migrate it to BYTEA, which'll do just fine.