-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
So we started seeing our regression results giving funny results. Basically it appeared like decent_ci was always comparing to some old baseline, instead of the current develop. We hadn't changed the yaml files to point the branch to a different ref.
Through some fun investigation, I figured out it was deciding to use an old pull request as the baseline. I think it's because of a combination of two things:
- the develop branch didn't move for a couple weeks after the 8.9.0 release (so it was no longer a potential build, or it was skipped, or whatever)
- the pull request came from a fork where the user made the changes on the develop branch itself
So in this block it looks like it tries to match up the nearest potential build coming from a develop branch. Normally this would be our own develop branch, but in this case it isn't. This should probably be protected to just use the root repo baseline branch, right?
I'm still confirming this, but it's all looking this way.
Metadata
Metadata
Assignees
Labels
No labels