Add OWNERS and tweak contributing instructions.

riannucci · Commit Bot · commit e5d16d016a30 · 2018-02-02T17:50:18.000Z
R=tandrii@chromium.org Change-Id: I619490d6f1e0a1a2b4822c59a63488a47c5bcbce Reviewed-on: https://chromium-review.googlesource.com/899663 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
diff --git a/OWNERS b/OWNERS
@@ -0,0 +1,3 @@
+dnj@chromium.org
+iannucci@chromium.org
+vadimsh@chromium.org
diff --git a/README.md b/README.md
@@ -29,24 +29,34 @@ Contributing
 
   * Sign the [Google CLA](https://cla.developers.google.com/clas).
   * Make sure your `user.email` and `user.name` are configured in `git config`.
+  * Install test-only packages:
+    `go get -u -t go.chromium.org/luci/client/...`
   * Install the [pcg](https://github.com/maruel/pre-commit-go) git hook:
     `go get -u github.com/maruel/pre-commit-go/cmd/... && pcg`
 
 Run the following to setup the code review tool and create your first review:
 
     git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
     export PATH="$PATH:$HOME/src/depot_tools"
-    cd $GOROOT/github.com/luci/gae
-    git new-branch work
-    # or `git checkout -b work origin/master` if you like typing more.
+    cd $GOROOT/go.chromium.org/luci
+    git checkout -b work origin/master
 
     # hack hack
-
-    git commit -a -m "This is awesome\nR=joe@example.com"
-    # This will ask for your Google Account credentials.
-    git cl upload -s
-    # Wait for LGTM over email.
-    # Check Commit Queue checkbox in Rietveld codereview site.
-    # See it tested and landed automatically.
+    git commit -a -m "This is awesome"
+
+    # We use Gerrit for code review. Visit
+    # https://chromium-review.googlesource.com/new-password
+    # and follow instructions.
+
+    git cl upload -s --r-owners
+    # This will upload your change to Gerrit and pick a random owner (as defined
+    # in the OWNERS file) for review.
+    # Wait for approval and submit your code through Commit Queue.
+    # Commit queue will test your change on multiple platforms and land it
+    # automatically.
+
+    # Once you get a review with comments, you can do additional commits to your
+    # feature branch, and then upload again to update the review in gerrit.
+    $ git cl upload
 
 Use `git cl help` and `git cl help <cmd>` for more details.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[email protected]`
	`2`	`+[email protected]`
	`3`	`+[email protected]`