Merge pull request gimli-rs#549 from the8472/copy-from-slice

philipc · web-flow · commit 705842a04d7a · 2021-02-08T11:38:53.000+10:00
use a more efficient method to copy [u8]
diff --git a/src/read/endian_reader.rs b/src/read/endian_reader.rs
@@ -469,7 +469,7 @@ where
     fn read_slice(&mut self, buf: &mut [u8]) -> Result<()> {
         match self.range.read_slice(buf.len()) {
             Some(slice) => {
-                buf.clone_from_slice(slice);
+                buf.copy_from_slice(slice);
                 Ok(())
             }
             None => Err(Error::UnexpectedEof(self.offset_id())),
diff --git a/src/read/endian_slice.rs b/src/read/endian_slice.rs
@@ -305,7 +305,7 @@ where
     #[inline]
     fn read_slice(&mut self, buf: &mut [u8]) -> Result<()> {
         let slice = self.read_slice(buf.len())?;
-        buf.clone_from_slice(slice);
+        buf.copy_from_slice(slice);
         Ok(())
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ where`
`469`	`469`	`fn read_slice(&mut self, buf: &mut [u8]) -> Result<()> {`
`470`	`470`	`match self.range.read_slice(buf.len()) {`
`471`	`471`	`Some(slice) => {`
`472`		`- buf.clone_from_slice(slice);`
	`472`	`+ buf.copy_from_slice(slice);`
`473`	`473`	`Ok(())`
`474`	`474`	`}`
`475`	`475`	`None => Err(Error::UnexpectedEof(self.offset_id())),`
Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ where`
`305`	`305`	`#[inline]`
`306`	`306`	`fn read_slice(&mut self, buf: &mut [u8]) -> Result<()> {`
`307`	`307`	`let slice = self.read_slice(buf.len())?;`
`308`		`- buf.clone_from_slice(slice);`
	`308`	`+ buf.copy_from_slice(slice);`
`309`	`309`	`Ok(())`
`310`	`310`	`}`
`311`	`311`	`}`