Support SAN for Go 1.15+ (#123)

vzlcn0 · web-flow · commit 88d20ddbfb85 · 2020-08-20T21:06:16.000-07:00
Starting from Go 1.15+ Certificate without subjectAltName will fail with error: "x509: certificate relies on legacy Common Name field" More info: golang/go#39568 This is only for Domain name and does not support IP Address: https://godoc.org/crypto/x509#Certificate
diff --git a/cert.go b/cert.go
@@ -89,6 +89,7 @@ func GenerateCertificateKey(commonName string, isCA bool, parent *x509.Certifica
 		NotAfter:    notAfter,
 		KeyUsage:    x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
 		ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
+		DNSNames:    []string{commonName},
 	}
 
 	if isCA {

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ func GenerateCertificateKey(commonName string, isCA bool, parent *x509.Certifica`
`89`	`89`	`NotAfter: notAfter,`
`90`	`90`	`KeyUsage: x509.KeyUsageKeyEncipherment \| x509.KeyUsageDigitalSignature,`
`91`	`91`	`ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},`
	`92`	`+ DNSNames: []string{commonName},`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`if isCA {`