remove duplicate componentDidMount (#531)

rithvikvibhu · web-flow · commit 534fb11aeef9 · 2022-07-06T21:45:29.000+05:30
diff --git a/app/components/SendModal/index.js b/app/components/SendModal/index.js
@@ -75,10 +75,6 @@ class SendModal extends Component {
     hip2.setServers([`127.0.0.1:${props.hip2Port}`]);
   }
 
-  componentDidMount () {
-    analytics.screenView('Send');
-  }
-
   openLinkHandler (e) {
     e.preventDefault()
     shell.openExternal(e.target.href)
@@ -170,6 +166,7 @@ class SendModal extends Component {
 
   componentDidMount = () => {
     document.addEventListener('keydown', this.handleEscape)
+    analytics.screenView('Send');
   }
 
   componentWillUnmount = () => {
diff --git a/app/components/Transactions/index.js b/app/components/Transactions/index.js
@@ -58,9 +58,7 @@ export default class Transactions extends Component {
     this.setState({
       itemsPerPage: itemsPerPage || 5,
     });
-  }
 
-  async componentDidMount() {
     await this.props.fetchTransactions();
   }
 
diff --git a/app/pages/Auction/index.js b/app/pages/Auction/index.js
@@ -101,9 +101,6 @@ export default class Auction extends Component {
     } finally {
       this.setState({isLoading: false});
     }
-  }
-
-  componentDidMount() {
     analytics.screenView('Auction');
   }
 
diff --git a/app/pages/DomainManager/index.js b/app/pages/DomainManager/index.js
@@ -66,17 +66,15 @@ class DomainManager extends Component {
       || this.state.itemsPerPage !== nextState.itemsPerPage;
   }
 
-  componentDidMount() {
-    analytics.screenView('Domain Manager');
-  }
-
   async componentDidMount() {
     this.props.getMyNames();
     const itemsPerPage = await dbClient.get(DM_ITEMS_PER_PAGE_KEY);
 
     this.setState({
       itemsPerPage: itemsPerPage || 10,
     });
+
+    analytics.screenView('Domain Manager');
   }
 
   onChange = (name) => (e) => {
diff --git a/app/pages/MyDomain/index.js b/app/pages/MyDomain/index.js
@@ -38,9 +38,6 @@ class MyDomain extends Component {
   async componentDidMount() {
     await this.props.getNameInfo();
     await this.props.fetchPendingTransactions();
-  }
-
-  componentDidMount() {
     analytics.screenView('My Domains');
   }
 
diff --git a/app/pages/Watching/index.js b/app/pages/Watching/index.js
@@ -60,9 +60,7 @@ class Watching extends Component {
     this.setState({
       itemsPerPage: itemsPerPage || 10,
     });
-  }
 
-  componentDidMount() {
     analytics.screenView('Watching');
   }
 

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,7 @@ export default class Transactions extends Component {`
`58`	`58`	`this.setState({`
`59`	`59`	`itemsPerPage: itemsPerPage \|\| 5,`
`60`	`60`	`});`
`61`		`- }`
`62`	`61`
`63`		`- async componentDidMount() {`
`64`	`62`	`await this.props.fetchTransactions();`
`65`	`63`	`}`
`66`	`64`
Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,6 @@ export default class Auction extends Component {`
`101`	`101`	`} finally {`
`102`	`102`	`this.setState({isLoading: false});`
`103`	`103`	`}`
`104`		`- }`
`105`		`-`
`106`		`- componentDidMount() {`
`107`	`104`	`analytics.screenView('Auction');`
`108`	`105`	`}`
`109`	`106`
Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,6 @@ class MyDomain extends Component {`
`38`	`38`	`async componentDidMount() {`
`39`	`39`	`await this.props.getNameInfo();`
`40`	`40`	`await this.props.fetchPendingTransactions();`
`41`		`- }`
`42`		`-`
`43`		`- componentDidMount() {`
`44`	`41`	`analytics.screenView('My Domains');`
`45`	`42`	`}`
`46`	`43`
Original file line number	Diff line number	Diff line change
`@@ -60,9 +60,7 @@ class Watching extends Component {`
`60`	`60`	`this.setState({`
`61`	`61`	`itemsPerPage: itemsPerPage \|\| 10,`
`62`	`62`	`});`
`63`		`- }`
`64`	`63`
`65`		`- componentDidMount() {`
`66`	`64`	`analytics.screenView('Watching');`
`67`	`65`	`}`
`68`	`66`