Add option for exporting JFR to specific directory. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Basically, I tried to follow internal implement of JMH. There is source code of LinuxPerfProfiler. |
Member
|
Looks good, could you add info about how to use it somewhere in the readme perhaps? |
ktoso
approved these changes
Jul 5, 2017
Author
|
Sure, I would try to add info to READM. By the way, I found original source code does work for absolute path, but not relative path( |
ktoso
approved these changes
Jul 17, 2017
Member
ktoso
left a comment
There was a problem hiding this comment.
Thanks :) I'll release tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108
Origin CLI - jmh:run -prof jmh.extras.JFR -t1 -f 1 -wi 10 -i 20 .TestBenchmark.
With Option - jmh:run -prof jmh.extras.JFR:--dir={dir} -t1 -f 1 -wi 10 -i 20 .TestBenchmark.