Use local file variable rather than updating field

headius · headius · commit 5aee3394951b · 2025-12-03T23:03:15.000-06:00
A change during 9.4.x accidentally modified this code to update the "file" field on RubyProc, rather than using a local variable. This restores that local variable and subsequent commits will make the fields final to avoid this happening in the future. Fixes #9110
diff --git a/core/src/main/java/org/jruby/RubyProc.java b/core/src/main/java/org/jruby/RubyProc.java
@@ -242,7 +242,7 @@ public IRubyObject to_s(ThreadContext context) {
         boolean isSymbolProc = block.getBody() instanceof RubySymbol.SymbolProcBody;
         if (isSymbolProc) {
             string.catStringUnsafe("(&:" + ((RubySymbol.SymbolProcBody) block.getBody()).getId() + ")");
-        } else if ((file = block.getBody().getFile()) != null) {
+        } else if (block.getBody().getFile() instanceof String file) {
             string.catStringUnsafe(" " + file + ":" + (block.getBody().getLine() + 1));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ public IRubyObject to_s(ThreadContext context) {`
`242`	`242`	`boolean isSymbolProc = block.getBody() instanceof RubySymbol.SymbolProcBody;`
`243`	`243`	`if (isSymbolProc) {`
`244`	`244`	`string.catStringUnsafe("(&:" + ((RubySymbol.SymbolProcBody) block.getBody()).getId() + ")");`
`245`		`- } else if ((file = block.getBody().getFile()) != null) {`
	`245`	`+ } else if (block.getBody().getFile() instanceof String file) {`
`246`	`246`	`string.catStringUnsafe(" " + file + ":" + (block.getBody().getLine() + 1));`
`247`	`247`	`}`
`248`	`248`