Skip to content

modman filters with chars following a '*' aren't parsed properly in move_files() #10

@jeffreyodum

Description

@jeffreyodum

If a module contains a modman file containing filters like "*{something}", files that match that filter are not deployed in move_files().

The problem happens when the modman file’s filter expression ends with “{something}”, like “app/etc/modules/.xml”.

Line 337 of modgit is:

line=”${line/*/}” # remove * char

Which means the comparison on line 339 of:

if [[ "$file" =~ ^$1 ]]

will fail in these cases as it will evaluate to something like:

if [[ "app/etc/local.xml.phpunit" =~ "app/etc/modules/.xml" ]]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions