Skip to content

Template docs incorrect #2204

@cristiano-belloni

Description

@cristiano-belloni

In https://github.com/jpmorganchase/modular/blob/caf75ab0f9638f6e13a34eecc66907391cdf0484/docs/concepts/templates.md

The strings PackageName__ and ComponentName__ present in any of the target files will be overwritten, respectively, by the target package name as-is and the target package name converted to PascalCase (the latter is useful for source code template files where, for example, a React component is created).

This is not true; currently we do that only for ts|tsx|js|jsx|json|md|txt files:

if (/\.(ts|tsx|js|jsx|json|md|txt)$/i.test(packageFilePath)) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions