Use only the first segment of the schema group #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4744bc to
d2c192b
Compare
The tool that generates the schemas in use here, https://github.com/instrumenta/openapi2jsonschema, shortens group names for Kubernetes definitions to just the first segment -- e.g., `apiextensions.k8s.io` gets the group `apiextensions`. The group is then used to name the schema file generated. This commit reproduces that logic in schema.js, so that it can find the right file for resources that have a dotted name as above. To be able to test the path construction in isolation, I moved things around a little, so access to resources is done from validate.js.
d2c192b to
4225d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool that generates the schemas in use here,
https://github.com/instrumenta/openapi2jsonschema, shortens group
names for Kubernetes definitions to just the first segment -- e.g.,
apiextensions.k8s.iogets the groupapiextensions. The group isthen used to name the schema file generated.
This commit reproduces that logic in the schema.js, so that it can
find the right file for resources that have a dotted name as above.
Fixes #69.