Skip to content

Conversation

ZacCranko
Copy link
Collaborator

No description provided.

@ZacCranko ZacCranko requested a review from yashk2810 April 14, 2025 17:12
@ZacCranko ZacCranko changed the title proper capitalizations, omitting things that shouldn't be documented [WIP] Amend documentation of JAX config options, include context managers, mechanism to hide flags Apr 14, 2025
capitalization_rules_list = [
("jax", "JAX"), ("xla", "XLA"), ("pgle", "PGLE"), ("cuda", "CUDA"), ("vjp", "VJP"), ("jvp", "JVP"),
("pjrt", "PjRT"), ("gpu", "GPU"), ("tpu", "TPU"), ("prng", "PRNG"), ("roocm", "ROOCM"), ("spmd", "SPMD"),
("bcoo", "BCOO"), ("jit", "JIT"), ("cpu", "CPU"), ("cusparse", "cuSPARSE"), ("ir", "IR"), ("dtype", "DType"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jit should be lowercaps.

roocm is misspelled? rocm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed rocm. These capitalization rules just get used to build the titles in the doc, so as an acronym jit I'm leaving jit capitalised.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PjRT -> PJRT

What about jit -> jit? Since it probably refers to the JAX API, not "Just In Time" (jax's API is kind of a misuse of the generic term, the verb is really "JIT compile")

Also numpy uses dtype, not Dtype, even when it's not dtype. There are examples in https://numpy.org/doc/2.1/reference/arrays.dtypes.html.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see Dtype because it's all Title Case. This is really yak shaving now but I personally prefer just capitalizing the first word, I think they look funny as Full Titles

Also nan -> NaN

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Apr 14, 2025
@ZacCranko ZacCranko removed kokoro:force-run pull ready Ready for copybara import and testing labels Apr 14, 2025
@ZacCranko ZacCranko self-assigned this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants