Shouldn't we remove the network prefix?

network/
  chain/
    account.go
    chain.go
    init.go
  network.go
  publish.go
  join.go

Shouldn't we remove the network prefix?

network/
  chain/
    account.go
    chain.go
    init.go
  network.go
  publish.go
  join.go

I changed the file names de3d77d but kept the networkchain dir name because we already have another chain pkg, it's better they have different names to make the import lines explicit.

I'm very comfortable with this design👍 I just have one comment on the naming above

Also, it may be out of scope for this refactor but I think Join should be independent from the chain object. You just pass a gentx path to Join and it makes the communication with spn checking accounts on spn, sending msg, etc...

And the verification related to the chain genesis like account already exists in the initial genesis or invalid gentx are perform in the chain package and called independently before Join But I think we can implement this in #1791

I was also thinking the same about Join, maybe it does not need to depend on Chain except that, it still needs to know the tendermint node id and we get it by executing a command on chain which requires Chain to be initialized.

I'm getting a new error:

starport n --local chain publish https://github.com/lubtd/earth --no-check
✔ Source code fetched
✔ Blockchain set up
cannot retrieve tokens from faucet: cannot send tokens (SDK code 32): account sequence mismatch, expected 1, got 0: incorrect account sequence

I'm looking into it, do you think it could be related to #1846?

[UPDATE] it seems I don't have the issue using --from alice and so occurs when using default

@lubtd can you please test again?

@lubtd can you please test again?

The issue persists for me but works on the second try

For each new account, the publish command fails on the first try but works on the next one

I created an issue for this one #1857, lets track it there to unblock this PR.

Yes it works the second time now