-
Notifications
You must be signed in to change notification settings - Fork 21
feat: text similar to 2119 boilerplate occurs but doesnt reference 2119 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Dmutre
wants to merge
14
commits into
ietf-tools:v3
from
Dmutre:feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119
Closed
feat: text similar to 2119 boilerplate occurs but doesnt reference 2119 #69
Dmutre
wants to merge
14
commits into
ietf-tools:v3
from
Dmutre:feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…oilerplate is missing - added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…hing-boilerplate-nor-a-reference-to-2119-is-missing
…oilerplate is missing - added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…ut-matching-boilerplate-is-missing' of https://github.com/Dmutre/idnits into feat/2119-keywords-occur,-a-reference-to-2119-exists,-but-matching-boilerplate-is-missing
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…use-2119-keywords' of https://github.com/Dmutre/idnits into feat/2119-boilerplate-is-present,-but-document-doesn't-use-2119-keywords
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
- added validation for not recommended keywords, when it is used but doesn`t mentioned in boilerplate - added validation for similar to rfc2119 boilerplate text, when correct boilerplate is not found - covered new validation with tests - changed chain of validation logic in validation function
…but-doesn't-reference-2119
ddfa276 to
e879442
Compare
rjsparks
requested changes
Jan 24, 2025
Member
rjsparks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think merge this with #68 (addressing the comments there that apply here) and we work on them together?
cdbd4e2 to
e32f974
Compare
e32f974 to
24a33e3
Compare
- fixed validation, removed errors that were duplicating - changed similar boilerplate detection
24a33e3 to
f070263
Compare
rjsparks
previously approved these changes
Jan 29, 2025
NGPixel
previously approved these changes
Jan 29, 2025
…ut-doesnt-reference-2119
Member
|
All changes already merged in #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.