Skip to content

Conversation

@Dmutre
Copy link
Collaborator

@Dmutre Dmutre commented Jan 23, 2025

No description provided.

Dmutre added 12 commits January 20, 2025 16:16
- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
…oilerplate is missing

- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
…hing-boilerplate-nor-a-reference-to-2119-is-missing
…oilerplate is missing

- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
…ut-matching-boilerplate-is-missing' of https://github.com/Dmutre/idnits into feat/2119-keywords-occur,-a-reference-to-2119-exists,-but-matching-boilerplate-is-missing
- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
…use-2119-keywords' of https://github.com/Dmutre/idnits into feat/2119-boilerplate-is-present,-but-document-doesn't-use-2119-keywords
- added validation for 4 points for 2119 keywords
- covered new validation with tests
- modified parser
- added validation for not recommended keywords, when it is used but doesn`t mentioned in boilerplate
- added validation for similar to rfc2119 boilerplate text, when correct boilerplate is not found
- covered new validation with tests
- changed chain of validation logic in validation function
@Dmutre Dmutre force-pushed the feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119 branch from ddfa276 to e879442 Compare January 24, 2025 10:01
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think merge this with #68 (addressing the comments there that apply here) and we work on them together?

@Dmutre Dmutre force-pushed the feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119 branch 2 times, most recently from cdbd4e2 to e32f974 Compare January 27, 2025 18:13
@Dmutre Dmutre requested a review from rjsparks January 28, 2025 15:08
@Dmutre Dmutre force-pushed the feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119 branch from e32f974 to 24a33e3 Compare January 28, 2025 15:11
- fixed validation, removed errors that were duplicating
- changed similar boilerplate detection
@Dmutre Dmutre force-pushed the feat/text-similar-to-2119-boilerplate-occurs-but-doesnt-reference-2119 branch from 24a33e3 to f070263 Compare January 29, 2025 15:20
rjsparks
rjsparks previously approved these changes Jan 29, 2025
NGPixel
NGPixel previously approved these changes Jan 29, 2025
@NGPixel NGPixel dismissed stale reviews from rjsparks and themself via c22da53 January 29, 2025 20:21
@NGPixel
Copy link
Member

NGPixel commented Jan 29, 2025

All changes already merged in #68

@NGPixel NGPixel closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants