feat: not recommended appears, but is not included in 2119 like boilerplate #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…oilerplate is missing - added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…hing-boilerplate-nor-a-reference-to-2119-is-missing
…oilerplate is missing - added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…ut-matching-boilerplate-is-missing' of https://github.com/Dmutre/idnits into feat/2119-keywords-occur,-a-reference-to-2119-exists,-but-matching-boilerplate-is-missing
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
…use-2119-keywords' of https://github.com/Dmutre/idnits into feat/2119-boilerplate-is-present,-but-document-doesn't-use-2119-keywords
- added validation for 4 points for 2119 keywords - covered new validation with tests - modified parser
- added validation for not recommended keywords, when it is used but doesn`t mentioned in boilerplate - added validation for similar to rfc2119 boilerplate text, when correct boilerplate is not found - covered new validation with tests - changed chain of validation logic in validation function
- added validation for not recommended keywords, when it is used but doesn`t mentioned in boilerplate - added validation for similar to rfc2119 boilerplate text, when correct boilerplate is not found - covered new validation with tests - changed chain of validation logic in validation function
rjsparks
previously approved these changes
Jan 21, 2025
…but-doesn't-reference-2119
…ded-in-2119-like-boilerplate
- fixed validation, removed errors that were duplicating - changed similar boilerplate detection
- added validation for not recommended keywords, when it is used but doesn`t mentioned in boilerplate - added validation for similar to rfc2119 boilerplate text, when correct boilerplate is not found - covered new validation with tests - changed chain of validation logic in validation function
…19-like-boilerplate' of https://github.com/Dmutre/idnits into feat/NOT-RECOMMENDED-appears,-but-is-not-included-in-2119-like-boilerplate
rjsparks
requested changes
Jan 24, 2025
Member
rjsparks
left a comment
There was a problem hiding this comment.
Some changes requested.
This doesn't test the parser, but I think we agreed that would come in another PR.
f8c0157 to
31987ca
Compare
31987ca to
fd26519
Compare
rjsparks
approved these changes
Jan 29, 2025
NGPixel
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.