Sync develop to master #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bbjj api: return err when hash fails while sign/verify
* Remove non-standard byte hasher and sponge hash construct on top of Poseidon. Remove BJJ wrapper functions. * Update deps * Update go versions * Fix GHA run targets * Remove non-standard byte hasher and sponge hash construct on top of Poseidon. Remove BJJ wrapper functions. * Update deps * Update go versions * Fix GHA run targets
vmidyllic
previously approved these changes
Jan 14, 2025
olomix
requested changes
Jan 14, 2025
babyjub/eddsa.go
Outdated
| if (left.X.Cmp(right.X) == 0) && (left.Y.Cmp(right.Y) == 0) { | ||
| return nil | ||
| } | ||
| return fmt.Errorf("verifyPoseidon failed") |
There was a problem hiding this comment.
I would create a sentinel error like ErrVarifyFailed and return it here. In this case we would be able to differentiate general error from validation fail by errors.Is instead of text comparison.
vmidyllic
approved these changes
Jan 21, 2025
olomix
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.