Theme system fixes and additions #19984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NABN00B
reviewed
Feb 15, 2025
| section.Get("PopupStyleFg", &info.uPopupStyleBg, info.uItemStyleFg); // Backwards compat | ||
| section.Get("PopupStyleFg", &info.uPopupStyleFg, info.uItemStyleFg); // Backwards compat | ||
| section.Get("PopupStyleBg", &info.uPopupStyleBg, info.uPopupStyleBg); | ||
| section.Get("PopupHeaderStyleFg", &info.uPopupHeaderStyleFg, info.uItemStyleFg); // Backwards compat |
There was a problem hiding this comment.
The comment mentions backwards compatibility but in that case these should be called PopupTitle* not PopupHeader*. Please clarify whether the new naming is intended or a mistake.
There was a problem hiding this comment.
Well it means backwards compatibility to what was before this change. I like PopupHeader better, and there are not a lot of old themes floating around really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #18802 , by implementing some of @NABN00B 's more recent suggestions. See commits for details.