Stabilize testCreateUserSessionsParallel model test

martin-kanis · hmlnarik · commit ff2669805399 · 2022-08-02T08:12:42.000+02:00
diff --git a/testsuite/model/src/test/java/org/keycloak/testsuite/model/session/UserSessionProviderModelTest.java b/testsuite/model/src/test/java/org/keycloak/testsuite/model/session/UserSessionProviderModelTest.java
@@ -53,6 +53,7 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Collectors;
 
@@ -296,20 +297,40 @@ public void testCreateUserSessionsParallel() throws InterruptedException {
                 (usMapStorageProvider == null || ConcurrentHashMapStorageProviderFactory.PROVIDER_ID.equals(usMapStorageProvider)));
 
         Set<String> userSessionIds = Collections.newSetFromMap(new ConcurrentHashMap<>());
+        CountDownLatch latch = new CountDownLatch(4);
 
-        inIndependentFactories(4, 30, () -> withRealm(realmId, (session, realm) -> {
-            UserModel user = session.users().getUserByUsername(realm, "user1");
-            UserSessionModel userSession = session.sessions().createUserSession(realm, user, "user1", "", "", false, null, null);
-            userSessionIds.add(userSession.getId());
+        inIndependentFactories(4, 30, () -> {
+            withRealm(realmId, (session, realm) -> {
+                UserModel user = session.users().getUserByUsername(realm, "user1");
+                UserSessionModel userSession = session.sessions().createUserSession(realm, user, "user1", "", "", false, null, null);
+                userSessionIds.add(userSession.getId());
 
-            return null;
-        }));
+                latch.countDown();
+
+                return null;
+            });
+
+            // wait for other nodes to finish
+            try {
+                latch.await();
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
 
-        assertThat(userSessionIds, Matchers.iterableWithSize(4));
+            assertThat(userSessionIds, Matchers.iterableWithSize(4));
 
-        withRealm(realmId, (session, realm) -> {
-            userSessionIds.forEach(id -> Assert.assertNotNull(session.sessions().getUserSession(realm, id)));
-            return null;
+            // wait a bit to allow replication
+            try {
+                Thread.sleep(1000);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
+
+            withRealm(realmId, (session, realm) -> {
+                userSessionIds.forEach(id -> Assert.assertNotNull(session.sessions().getUserSession(realm, id)));
+
+                return null;
+            });
         });
     }
 }
