maint: remove deprecated config options (#1689)

VinozzZ · web-flow · commit da61d321b60d · 2025-09-26T10:39:05.000-04:00
## Which problem is this PR solving?

This PR removes several deprecated configuration options from Refinery.
These changes clean up the configuration API by removing functionality
that was either deprecated or no longer needed.

This PR only removes the config options. The actual code logic removal
will be done in the future release

## Short description of the changes

Configuration Removal:
- BufferSizes section: Completely removed BufferSizes configuration
group including:
    - UpstreamBufferSize
    - PeerBufferSize
  - Collection section cleanup: Removed several fields that
  were part of the TraceLocalityMode feature:
    - DisableRedistribution
    - RedistributionDelay
    - MaxDropDecisionBatchSize
    - DropDecisionSendInterval
    - MaxKeptDecisionBatchSize
    - KeptDecisionSendInterval
diff --git a/collect/stress_relief_test.go b/collect/stress_relief_test.go
@@ -330,6 +330,7 @@ func newStressRelief(t *testing.T, clock clockwork.Clock, channel pubsub.PubSub)
 
 	sr := &StressRelief{
 		Clock:           clock,
+		Done:            make(chan struct{}),
 		Logger:          logger,
 		RefineryMetrics: metric,
 		PubSub:          channel,
@@ -338,6 +339,7 @@ func newStressRelief(t *testing.T, clock clockwork.Clock, channel pubsub.PubSub)
 	}
 
 	return sr, func() {
+		close(sr.Done)
 		require.NoError(t, healthReporter.Stop())
 		require.NoError(t, channel.Stop())
 	}
diff --git a/config/config_serializer.go b/config/config_serializer.go
@@ -64,7 +64,6 @@ func populateConfigContents(cfg Config) configContents {
 		PeerManagement:      getPeerManagementConfig(cfg),
 		RedisPeerManagement: cfg.GetRedisPeerManagement(),
 		Collection:          cfg.GetCollectionConfig(),
-		BufferSizes:         BufferSizeConfig{},
 		Specialized: SpecializedConfig{
 			EnvironmentCacheTTL:       Duration(cfg.GetEnvironmentCacheTTL()),
 			CompressPeerCommunication: getDefaultTrueValue(cfg.GetCompressPeerCommunication()),
diff --git a/config/file_config.go b/config/file_config.go
@@ -62,7 +62,6 @@ type configContents struct {
 	PeerManagement       PeerManagementConfig      `yaml:"PeerManagement"`
 	RedisPeerManagement  RedisPeerManagementConfig `yaml:"RedisPeerManagement"`
 	Collection           CollectionConfig          `yaml:"Collection"`
-	BufferSizes          BufferSizeConfig          `yaml:"BufferSizes"`
 	Specialized          SpecializedConfig         `yaml:"Specialized"`
 	IDFieldNames         IDFieldsConfig            `yaml:"IDFields"`
 	GRPCServerParameters GRPCServerParameters      `yaml:"GRPCServerParameters"`
@@ -319,8 +318,8 @@ type CollectionConfig struct {
 	MaxMemoryPercentage int        `yaml:"MaxMemoryPercentage" default:"75"`
 	MaxAlloc            MemorySize `yaml:"MaxAlloc"`
 
-	DisableRedistribution *DefaultTrue `yaml:"DisableRedistribution" default:"true"` // Avoid pointer woe on access, use GetDisableRedistribution() instead.
-	RedistributionDelay   Duration     `yaml:"RedistributionDelay" default:"30s"`
+	DisableRedistribution *DefaultTrue `yaml:"-"` // Avoid pointer woe on access, use GetDisableRedistribution() instead.
+	RedistributionDelay   Duration     `yaml:"-"`
 
 	ShutdownDelay     Duration `yaml:"ShutdownDelay" default:"15s"`
 	TraceLocalityMode string   `yaml:"-"`
@@ -367,8 +366,6 @@ func (c CollectionConfig) TraceLocalityEnabled() bool {
 	}
 }
 
-type BufferSizeConfig struct{}
-
 type SpecializedConfig struct {
 	EnvironmentCacheTTL       Duration          `yaml:"EnvironmentCacheTTL" default:"1h"`
 	CompressPeerCommunication *DefaultTrue      `yaml:"CompressPeerCommunication" default:"true"` // Avoid pointer woe on access, use GetCompressPeerCommunication() instead.
diff --git a/config/metadata/configMeta.yaml b/config/metadata/configMeta.yaml
@@ -1365,6 +1365,7 @@ groups:
         type: defaulttrue
         valuetype: nondefault
         firstversion: v2.8
+        lastversion: v2.9.7
         default: true
         reload: true
         summary: controls whether to transmit traces in cache to remaining peers during cluster scaling event.
@@ -1383,6 +1384,7 @@ groups:
         type: duration
         valuetype: nondefault
         firstversion: v2.9
+        lastversion: v2.9.7
         default: 30s
         reload: false
         summary: controls the amount of time Refinery waits after each cluster scaling event before redistributing in-memory traces.
@@ -1505,6 +1507,7 @@ groups:
 
   - name: BufferSizes
     title: "Buffer Sizes"
+    lastversion: v2.9.7
     description: >
       contains the settings that are relevant to
       the sizes of communications buffers.
@@ -1514,7 +1517,6 @@ groups:
         valuetype: nondefault
         default: 10_000
         reload: true
-        lastversion: v2.9.7
         validations:
           - type: minimum
             arg: 1_000
@@ -1530,7 +1532,6 @@ groups:
         valuetype: nondefault
         default: 100_000
         reload: true
-        lastversion: v2.9.7
         validations:
           - type: minimum
             arg: 10_000

Original file line number	Diff line number	Diff line change
`@@ -330,6 +330,7 @@ func newStressRelief(t *testing.T, clock clockwork.Clock, channel pubsub.PubSub)`
`330`	`330`
`331`	`331`	`sr := &StressRelief{`
`332`	`332`	`Clock: clock,`
	`333`	`+ Done: make(chan struct{}),`
`333`	`334`	`Logger: logger,`
`334`	`335`	`RefineryMetrics: metric,`
`335`	`336`	`PubSub: channel,`
`@@ -338,6 +339,7 @@ func newStressRelief(t *testing.T, clock clockwork.Clock, channel pubsub.PubSub)`
`338`	`339`	`}`
`339`	`340`
`340`	`341`	`return sr, func() {`
	`342`	`+ close(sr.Done)`
`341`	`343`	`require.NoError(t, healthReporter.Stop())`
`342`	`344`	`require.NoError(t, channel.Stop())`
`343`	`345`	`}`