Skip to content

Commit 088125f

Browse files
authored
feat: set default value for SpanLimit to 32k (#1768)
## Which problem is this PR solving? Currently, Refinery has no default hard limit on the number of spans it will buffer per trace. This means that giant traces can overload a single Refinery node. ## Short description of the changes - set 32k as the default value
1 parent 1ae8442 commit 088125f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

config/file_config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ type TracesConfig struct {
200200
TraceTimeout Duration `yaml:"TraceTimeout" default:"60s"`
201201
MaxBatchSize uint `yaml:"MaxBatchSize" default:"500"`
202202
SendTicker Duration `yaml:"SendTicker" default:"100ms"`
203-
SpanLimit uint `yaml:"SpanLimit"`
203+
SpanLimit uint `yaml:"SpanLimit" default:"32000"` // Set the default span limit to be the same as the limit for trace view in Honeycomb
204204
MaxExpiredTraces uint `yaml:"MaxExpiredTraces" default:"3000"`
205205
}
206206

config/metadata/configMeta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ groups:
397397
type: int
398398
valuetype: nondefault
399399
firstversion: v2.8
400-
default: 0
400+
default: 32000
401401
reload: true
402402
summary: is the number of spans after which a trace becomes eligible for a trace decision.
403403
description: >

0 commit comments

Comments
 (0)